Use `remq` instead of `delq` in `selectrum-prescient-create-and-bind-toggle-command`.

radian-software / prescient.el

☄️ Simple but effective sorting and filtering for Emacs.

MIT License

614 stars 25 forks source link

Use `remq` instead of `delq` in `selectrum-prescient-create-and-bind-toggle-command`. #124

Closed okamsn closed 2 years ago

okamsn commented 2 years ago

Even though we use make-local-variable to ensure that prescient-filter-method is buffer-local in the minibuffer, it seems that delq might still modify prescient-filter-method as a global variable. It was assumed that destructive functions would only modify the buffer-local value, but that is apparently not the case.

See also issue #123.

okamsn commented 2 years ago

@raxod502, would you please re-invite me to the GitHub organization so that I can merge this? I see that I missed the e-mail the first time.

raxod502 commented 2 years ago

Yes, sorry, done. Also, will go ahead and merge this for you now.