Fix identifying full matches in some cases.

radian-software / prescient.el

☄️ Simple but effective sorting and filtering for Emacs.

MIT License

614 stars 25 forks source link

Fix identifying full matches in some cases. #149

Closed okamsn closed 1 year ago

okamsn commented 1 year ago

Fixes #147. Builds upon #148.

Change how regexps from filter methods added to candidates.
Fix filter method prefix so that it doesn't match more than intended. Other methods might also need to be changed.

raxod502 commented 1 year ago

Since this changes some behavior, I went ahead and finally added a unit test framework for prescient.el (https://github.com/radian-software/prescient.el/pull/150) and added some tests covering your changes (https://github.com/radian-software/prescient.el/pull/149/commits/5a194bba9398059e26e745259ff3f1b7b09073d7). Does that look good to you?

okamsn commented 1 year ago

Thank you for adding the test framework. Writing the tests helped me find another bug in prefix.

This PR builds on top of #148. Do you want to merge that one, then this one, or do you just want to merge this one? If the latter, do you want this one to be made into a single commit?
Do you care whether the properties attached to the candidates for sorting are keyword symbols or normal symbols?

raxod502 commented 1 year ago

Do you want to merge that one, then this one, or do you just want to merge this one? If the latter, do you want this one to be made into a single commit?

Any way is fine with me. Feel free to merge them yourself, or I can do it.

Do you care whether the properties attached to the candidates for sorting are keyword symbols or normal symbols?

You can do it either way; I have no opinion.