Closed okamsn closed 10 months ago
✨ Looks fine, although I do have a comment at #156 (comment). I looked at the actual runtime and I see building the Docker image only takes 15 seconds, so I guess it doesn't matter too much. Is the motivation for splitting the make targets out into a matrix to report easier to read results on the GitHub status checks?
Yes, but I realized that I was focusing on the wrong thing when I wrote this. For #156, it only needs that the "Package Require" line can be longer than 80 characters. I meant to make a new PR for just that, but accidentally pushed that change to the main
branch instead of creating a PR. My apologies.
No worries!
vertico-prescient.el
with Emacs versions less than that. This makes implementations a bit simpler.docker
make
target.