search

radian-software / prescient.el

☄️ Simple but effective sorting and filtering for Emacs.
MIT License
603 stars 25 forks source link

Use corfu--initial-state instead of corfu--initial-state #159

Closed zonuexe closed 8 months ago

zonuexe commented 8 months ago

Fixes https://github.com/radian-software/prescient.el/issues/158

I don't have a good understanding of corfu and prescient, so I haven't confirmed that they work properly. This patch may be insufficient. In that case, please feel free to close this PR.

okamsn commented 8 months ago

This seems to work for me. Thank you for making this pull request.

@raxod, how do you want to handle the changed variable? Do you want the Prescient code to still work with the older variable until a new stable version of Corfu is published (which this PR currently does)?

raxod502 commented 8 months ago

That seems prudent, if the change was recent, then people might be using either the new version or the old version. Unless it's difficult, it makes sense to me to support both.

Of course, it goes without saying that it'd be nice if there were a public interface exposed that could be used instead.

zonuexe commented 8 months ago

Currently, the package dependencies are as follows:

;; Package-Requires: ((emacs "27.1") (prescient "6.1.0") (corfu "0.28"))

Corfu has been released 10 times since 0.28, but the variable change was included in 1.1.

okamsn commented 8 months ago

Currently, the package dependencies are as follows:

;; Package-Requires: ((emacs "27.1") (prescient "6.1.0") (corfu "0.28"))

Corfu has been released 10 times since 0.28, but the variable change was included in 1.1.

I think that Emacs treats the 0.28 as a minimum version number, so it shouldn't cause any problems for the version before the change. Still, I have bumped it to 1.1. I will increase the required version number again once the next stable version of Corfu is released.

I have merged the PR. Thanks to those that created the issue and thank you for providing the fix.

zonuexe commented 8 months ago

@okamsn Thanks for improving and merging!