search

radian-software / radian

🍉 Dotfiles that marry elegance and practicality.
MIT License
490 stars 47 forks source link

Aggregate global Radian keybindings into minor mode map #485

Closed hrehfeld closed 1 year ago

hrehfeld commented 3 years ago

We could also take this one step further and create modes for each feature:

radian-mwheel-mode-map etc.

raxod502 commented 3 years ago

For global keybindings, that seems reasonable, the only thing is we have to be careful with testing, since minor modes have precedence rules that are quite different from the global keymap.

raxod502 commented 1 year ago

All Radian bindings are now in radian-keymap, which is bound on a prefix. I don't think we get a lot more out of putting that single prefix binding into a keymap of its own; bind-key* actually does that transparently. But let me know if you disagree.

hrehfeld commented 1 year ago

Awesome, thanks!

28 Feb 2023 06:20:17 Radon Rosborough @.***>:

Closed #485[https://github.com/radian-software/radian/issues/485] as completed.

— Reply to this email directly, view it on GitHub[https://github.com/radian-software/radian/issues/485#event-8622873926], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAATX57BX65CA7OQBAZLR4TWZWDINANCNFSM47ABFNZQ]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AAATX574WVACX74QDUMRZFTWZWDINA5CNFSM47ABFNZ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGPAAAAAAQB62OUM.gif]