search

radian-software / radian

🍉 Dotfiles that marry elegance and practicality.
MIT License
491 stars 47 forks source link

radian-bind-key is an unnecessary dependency on "frameworky" code #488

Closed hrehfeld closed 1 year ago

hrehfeld commented 3 years ago

https://github.com/raxod502/radian/blob/develop/emacs/radian.el#L670

Instead of having to remember the name of the radian-keymap you now have to remember the name of the radian-bind-key function, and severely reduce composability.

raxod502 commented 3 years ago

Hmmm... but nothing stops you from binding directly in radian-keymap, does it? The point of the macro is just to save a few characters.

hrehfeld commented 1 year ago

:+1: thank you!

28 Feb 2023 05:15:28 Radon Rosborough @.***>:

Closed #488[https://github.com/radian-software/radian/issues/488] as completed via be3b3e2[https://github.com/radian-software/radian/commit/be3b3e25664020f3d8c800d54b5f2dbc7686aced].

— Reply to this email directly, view it on GitHub[https://github.com/radian-software/radian/issues/488#event-8622595509], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAATX56QLH6XERI3PEB5FHLWZV3U7ANCNFSM47DKR7NA]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AAATX56FP3G6Q2FW3RTSKGLWZV3U7A5CNFSM47DKR7NKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGPAAAAAAQB6JO3K.gif]