search

radian-software / radian

🍉 Dotfiles that marry elegance and practicality.
MIT License
491 stars 47 forks source link

Try replacing Selectrum with Vertico #505

Closed raxod502 closed 1 year ago

raxod502 commented 2 years ago

Per https://github.com/radian-software/selectrum/issues/598#issuecomment-1121682815

minad commented 1 year ago

I think for prescient to work you also have to remember the selected candidates in the completion UI. Maybe @okamsn could take a look here and help with a migration guide?

(advice-add #'vertico-insert :after
            (lambda () (prescient-remember (vertico--candidate))))
okamsn commented 1 year ago

There is the section on the Vertico wiki: https://github.com/minad/vertico/wiki#using-prescientel-filtering-and-sorting. It is what I'm doing, more or less.

For a migration guide, do you mean one mapping Selectrum features to Vertico+extensions features? Would that be put on the Vertico wiki?

minad commented 1 year ago

@okamsn Sure, if you have more information about common Selectrum to Vertico migration issues, or mappings of certain features, feel free to add this to the Vertico wiki.

okamsn commented 1 year ago

@minad, I've made a mapping of the settings and features: https://github.com/minad/vertico/wiki/Migrating-from-Selectrum-to-Vertico

I put it on a new page since it felt separate from the content of the other page. Please edit it as you see fit (or let me know what should be changed). The GitHub wiki doesn't seem to accept Org footnotes, so I need to go back and clean those up.

minad commented 1 year ago

@okamsn Thanks! This looks already pretty great and covers a lot of ground. When I find time I will go over it again.

raxod502 commented 1 year ago

Ok, I've been using this for a couple months and I think it's good to go. Will follow up with migrating to vertico-prescient-mode after https://github.com/radian-software/prescient.el/pull/131 is merged.