radian-software / radian

🍉 Dotfiles that marry elegance and practicality.
MIT License
491 stars 47 forks source link

Add a compilation flag #517

Closed haji-ali closed 1 year ago

haji-ali commented 1 year ago

In my init file, I sometimes output some helpful messages (mostly diagnostics) which cause Radian's make file to fail since it considers any output in the compilation process an error.

There are two ways to solve this:

raxod502 commented 1 year ago

I'm fine with this solution. I don't necessarily think it is a good idea to try to run with --no-local, because it is important to byte-compile the local init-file, as well.

It would probably be better, to be honest, to make the output check more intelligent, so that it only fails on actual errors or critical warnings.

I wonder what's up with that compilation error in Emacs 27?

raxod502 commented 1 year ago

Okay, it was somehow a flake, I guess. I re-ran the action and it passed.

haji-ali commented 1 year ago

I don't necessarily think it is a good idea to try to run with --no-local, because it is important to byte-compile the local init-file, as well.

I see. I was under the impression that the emacs instance being called in byte-compile.bash doesn't actually need the local configuration to be loaded to compile said configuration (and embed them in radian.el). Perhaps I am missing something.

Anyways, thanks for the merging this change.

raxod502 commented 1 year ago

It might be possible to arrange for the local configuration to be byte-compiled without loading it, but the general assumption is that code is loaded before it's byte-compiled. Otherwise some odd things can happen, which require additional care to make sure they work.