radian-software / radian

🍉 Dotfiles that marry elegance and practicality.
MIT License
491 stars 47 forks source link

Fix compilation warnings on emacs 29.0.60 #518

Closed haji-ali closed 1 year ago

haji-ali commented 1 year ago

This fixes a couple of warnings on emacs 29.0.60. The first is an unescaped single quotation. The other warning come from radian--lsp-enable where using # issues a warning when the functions are not defined (they would be if the corresponding packages are disabled).

There is another deprecation warning for using point-at-eol which should be changed to pos-eol, but I don't know if you want to define this function in earlier versions of emacs or maybe use compat.

raxod502 commented 1 year ago

Fair enough.

raxod502 commented 1 year ago

For point-at-eol, I'm fine with compat or alternatively using a backwards compatibility definition as I do for some other functions.