radian-software / radian

🍉 Dotfiles that marry elegance and practicality.
MIT License
491 stars 47 forks source link

emacs 29 changes and change --no-local #527

Closed haji-ali closed 1 year ago

haji-ali commented 1 year ago

This has several changes which I found useful, but I am not sure which ones would be wanted by others, so I am creating this PR as draft.

haji-ali commented 1 year ago

EDIT: Thinking more about it, perhaps --no-local-after-init is best left for the user to implement. Instead, I implemented a configuration to avoid pruning when the local after-init is not run.

The thing I don't quite like about --no-local (and correct me if I am wrong) is that when radian is compiled, passing --no-local causes the local config (outside hooks) not to run, but hooks still run as usual. So this option is only relevent when radian is not compiled.

raxod502 commented 1 year ago

Oh dang, I didn't realize local configuration hooks would still be run with --no-local. That's definitely a bug. Filed https://github.com/radian-software/radian/issues/528 to track.