radian-software / selectrum

🔔 Better solution for incremental narrowing in Emacs.
MIT License
739 stars 33 forks source link

Marginalia annotations disappear with prompt selection on `find-file` #561

Open iyefrat opened 3 years ago

iyefrat commented 3 years ago

Using find-file, moving the selection up to the prompt line will cause marginalia annotations to disappear if the path in the prompt is in a separate directory than one you first run the command in.

To reproduce, open emacs -Q and eval the following:

(require 'package)
(add-to-list 'package-archives '("melpa" . "https://melpa.org/packages/") t)
(package-initialize)
(package-refresh-contents)
(package-install 'marginalia)
(require 'marginalia)
(marginalia-mode)
(package-install 'selectrum)
(selectrum-mode +1)

Then, run find-file, navigate to a different directory in it, and move the selection up to the prompt line. When you have some partial path in the same directory you started in, moving the selection up to the prompt line doesn't cause the annotations to disappear, but this seems to happen for any other directory you move to. This is definitely an issue on the selectrum side since I can't reproduce this on vertico.

cc: @minad

minad commented 3 years ago

I just checked this. This is indeed a Selectrum bug, selectrum--get-full seems to return a wrong value in that case.