search

radian-software / sleeping-beauty

🌹 Webserver auto-sleep for containerized environments.
MIT License
24 stars 1 forks source link

Zombie processes not reaped #1

Closed raxod502 closed 2 years ago

raxod502 commented 2 years ago

Using sleepingd as pid1 in a docker container fails to reap zombie processes per https://blog.phusion.nl/2015/01/20/docker-and-the-pid-1-zombie-reaping-problem/. Either we need to implement this or (more likely) we need to include phusion's pid1 in the release docker image and recommend its usage in any downstream application that uses sleepingd.

Nick-Triller commented 2 years ago

tini and dumb-init are some potential alternatives to phusion's pid1.

raxod502 commented 2 years ago

Good call. We now use tini for integration tests, and I will update the README to recommend its usage in production as well. https://github.com/radian-software/sleeping-beauty/blob/7693fc5a6cc2f9850fbd1e1e6f72f457663bc3bb/test/integration/run_in_docker.bash#L26-L29