search

radian-software / straight.el

🍀 Next-generation, purely functional package manager for the Emacs hacker.
MIT License
2.75k stars 151 forks source link

straight doesn't seem to handle emacs-sqlite-builtin properly #1108

Closed colonelpanic8 closed 1 year ago

colonelpanic8 commented 1 year ago

What's wrong

See this comment: https://github.com/org-roam/org-roam/issues/2146#issuecomment-1649488358

progfolio commented 1 year ago

Please fill out the bug report with the information requested in the template:

## What's wrong

## Directions to reproduce

<!--
Please give instructions for how to reproduce the behavior _starting from an empty `~/.emacs.d`_. Unfortunately, I simply don't have enough time to check out your bug report unless it has clear instructions for this.

straight.el provides a macro, `straight-bug-report`, which can be used to easily create a minimal reproduction case in a clean Emacs environment. Please use this if possible. For instructions, see <https://github.com/radian-software/straight.el#debugging> and the `straight-bug-report` docstring.

If `straight-bug-report` is not available or fails you can still create a reproduction case manually. To do this, start with an empty `~/.emacs.d/init.el`, add the bootstrap snippet, and then add any additional code from your init-file that's needed to set up the buggy behavior. Then include a list of steps to follow (commands to run, files to modify, whatever) after Emacs startup.

Make sure you're using the latest version of straight.el. You can do this by including (setq straight-repository-branch "develop") in your init-file before the bootstrap snippet.

Also, unless you are already quite certain that your problem is specific to straight.el, please verify that it cannot be reproduced using package.el. If you can reproduce your problem with package.el, then it's not a bug in straight.el and I can't do anything about it!

If you try these steps and can't reproduce the problem, it must be something particular to your environment or configuration. In this case, you'll have to bisect in order to figure out what is causing the problem. I won't be able to debug a problem that only happens on your computer!
-->

### Version information

* Emacs version:
* Operating system:

Linking to a comment isn't great because it may be edited or deleted. Providing the information above will ensure we can help you. Thanks.

progfolio commented 1 year ago

From the linked comment:

To fix the error, you need to manually add two more symlinks that straight.el seems to miss:

emacsql-sqlite-common.el ⇒ ~/.emacs.d/straight/repos/emacsql/emacsql-sqlite-common.el
emacsql-sqlite.el ⇒ ~/.emacs.d/straight/repos/emacsql/emacsql-sqlite.el

Unable to reproduce with the following test case:

Test Case ```emacs-lisp (straight-bug-report :post-bootstrap (straight-use-package 'emacsql) (print (straight--process-output "ls" "-lah" (straight--build-dir "emacsql")))) ```
Output ```emacs-lisp Bootstrapping straight.el... Bootstrapping straight.el...done Looking for gnu-elpa-mirror recipe → Cloning melpa... Looking for gnu-elpa-mirror recipe → Cloning melpa...done Looking for nongnu-elpa recipe → Cloning gnu-elpa-mirror... Looking for nongnu-elpa recipe → Cloning gnu-elpa-mirror...done Looking for emacsmirror-mirror recipe → Cloning nongnu-elpa... Looking for emacsmirror-mirror recipe → Cloning nongnu-elpa...done Looking for emacsmirror-mirror recipe → Cloning el-get... Looking for emacsmirror-mirror recipe → Cloning el-get...done Looking for straight recipe → Cloning emacsmirror-mirror... Looking for straight recipe → Cloning emacsmirror-mirror...done Building straight... Building straight...done Test run with version: prerelease (HEAD -> develop, origin/develop) 095aee3 2023-08-07 Cloning emacsql... Cloning emacsql...done Building emacsql... Building emacsql...done "total 108K drwxr-xr-x 3 n n 440 Aug 7 22:27 . drwxr-xr-x 4 n n 80 Aug 7 22:27 .. -rw-r--r-- 1 n n 1.8K Aug 7 22:27 emacsql-autoloads.el lrwxrwxrwx 1 n n 71 Aug 7 22:27 emacsql-compiler.el -> /tmp/straight.el-test-UfspM9/straight/repos/emacsql/emacsql-compiler.el -rw-r--r-- 1 n n 23K Aug 7 22:27 emacsql-compiler.elc lrwxrwxrwx 1 n n 62 Aug 7 22:27 emacsql.el -> /tmp/straight.el-test-UfspM9/straight/repos/emacsql/emacsql.el -rw-r--r-- 1 n n 17K Aug 7 22:27 emacsql.elc lrwxrwxrwx 1 n n 68 Aug 7 22:27 emacsql-mysql.el -> /tmp/straight.el-test-UfspM9/straight/repos/emacsql/emacsql-mysql.el -rw-r--r-- 1 n n 6.9K Aug 7 22:27 emacsql-mysql.elc lrwxrwxrwx 1 n n 65 Aug 7 22:27 emacsql-pg.el -> /tmp/straight.el-test-UfspM9/straight/repos/emacsql/emacsql-pg.el -rw-r--r-- 1 n n 4.5K Aug 7 22:27 emacsql-pg.elc lrwxrwxrwx 1 n n 67 Aug 7 22:27 emacsql-psql.el -> /tmp/straight.el-test-UfspM9/straight/repos/emacsql/emacsql-psql.el -rw-r--r-- 1 n n 6.3K Aug 7 22:27 emacsql-psql.elc lrwxrwxrwx 1 n n 77 Aug 7 22:27 emacsql-sqlite-builtin.el -> /tmp/straight.el-test-UfspM9/straight/repos/emacsql/emacsql-sqlite-builtin.el -rw-r--r-- 1 n n 4.1K Aug 7 22:27 emacsql-sqlite-builtin.elc lrwxrwxrwx 1 n n 76 Aug 7 22:27 emacsql-sqlite-common.el -> /tmp/straight.el-test-UfspM9/straight/repos/emacsql/emacsql-sqlite-common.el -rw-r--r-- 1 n n 9.8K Aug 7 22:27 emacsql-sqlite-common.elc lrwxrwxrwx 1 n n 69 Aug 7 22:27 emacsql-sqlite.el -> /tmp/straight.el-test-UfspM9/straight/repos/emacsql/emacsql-sqlite.el -rw-r--r-- 1 n n 7.4K Aug 7 22:27 emacsql-sqlite.elc lrwxrwxrwx 1 n n 76 Aug 7 22:27 emacsql-sqlite-module.el -> /tmp/straight.el-test-UfspM9/straight/repos/emacsql/emacsql-sqlite-module.el -rw-r--r-- 1 n n 4.1K Aug 7 22:27 emacsql-sqlite-module.elc drwxr-xr-x 2 n n 120 Aug 7 22:27 sqlite" Packages: "straight" n/a develop 095aee3 2023-08-07 "org-elpa" n/a n/a "melpa" n/a master fc5b27dd 2023-08-07 "gnu-elpa-mirror" n/a master be1351c 2023-07-14 "nongnu-elpa" n/a main 65b952d 2023-08-04 "el-get" melpa master f3f1edd4 2023-07-25 "emacsmirror-mirror" n/a master 8e7cbfe 2023-08-07 "emacsql" melpa main 6401226 2023-04-17 ```
colonelpanic8 commented 1 year ago

The issue is with emacsql-sqlite-builtin. I think it may have had to do with recent changes to the recipe, but now things seem to be working fine for me after I pulled all the recipe sources. The user's claim in the linked comment is wrong though, since those files are part of the core emacssql package.