Open chrismou opened 8 years ago
We should take a look at our existing themes and see if they are possible to recreate with gmusic-theme.js
. If so, I say we fully switch, if not, we should PR gmusic-theme.js
or create our own extension library.
In general, I'm against pure-css themes, and for having a pure-css override (i.e. the base theme should be defined by JSON / JS, and any complex customization should happen in CSS, IMO).
Looking at the themes, we can mostly recreate them all using the gmusic-theme functionality.
But as far as end user experience goes, this is my thinking:
My thinking with the themes is in future we could even potentially create a page in the settings to "upload" a theme into your local Radiant in zip format and have it import the theme, so people can share their creations. Could be interesting.
Need to decide whether we're sticking with the current model (custom made themes) or a more generic theming function (see https://github.com/gmusic-utils/gmusic-theme.js).
Personal preference - implement gmusic-theme for fine grained theming control, but also include some "pre made" theme options, which will essentially just set the gmusic-theme values to whatever (ie, dark grey background, white text and cyan stroke for the "Dark Cyan" theme).
Depends on #3 for somewhere to put the options