radiant-player / radiant-player-mac

:notes: Turn Google Play Music into a separate, beautiful application that integrates with your Mac.
http://radiant-player.github.io/radiant-player-mac/
MIT License
3k stars 261 forks source link

Constantly freezes on Yosemite (10.10) #262

Closed DataGreed closed 9 years ago

DataGreed commented 9 years ago

Player constantly freezes after playing 1-2 songs. The music itself continues playing and tracks keep changing forward, though media keys stop working, the player window becomes unresponsive (pinwheel cursor) and there's a pinwheel cursor above the tray icon.

I'm using mac pro 4,1 if it's any help and Radiant 1.3.1

DataGreed commented 9 years ago

Here's the hang log (not sure if it's connected with the problem, but the timing suggests it is) – https://gist.github.com/DataGreed/b46e3f584e360960c562

DataGreed commented 9 years ago

Actually, there's a lot going on there, here's the screenshot:

2014-11-13 20 03 02

belak commented 9 years ago

Every once in a while, it will freeze, the audio will get stuck and I'll have to force close it as well.

hankish commented 9 years ago

This is happening to me as well. The audio keeps freezing and making a sort of stuttering sound. It seems to happen mostly on track changes and while the audio is stuck the app and its associated menu bar icon show the spinning pinwheel.

I"m running an iMac with OS X v 10.10. I'll post any other info you want if you tell me what to do.

hu5h55 commented 9 years ago

I am experiencing the constant freezes also. Say, after 2½ songs or so. Yosemite 10.10

dodgepong commented 9 years ago

This is happening to me as well, freezing after a few songs. Is there anything needed in terms of logging or testing that we can do to help narrow down the cause?

oldit555 commented 9 years ago

I have problem with cpu load(10.10), when I use pause for some time(with mac ctrl button) cpu load is about 100% in activity monitor. And unpause didn't help too, only restart app help me to down cpu load, about 5% normally http://take.ms/xroV5

MiguelLavigne commented 9 years ago

I've been experiencing the same problem as well. For me if I leave it frozen long enough it eventually comes out of it and resumes playing the song.

I had noticed that the new song notifications would always display late for some reason. I decided to turn them off just to check and suddenly the freezing bug disappeared. Not sure if they are related but I just don't have that freeze bug now that I've disabled the new song notifications from the settings.

nicolasembleton commented 9 years ago

Same for me but under Mavericks... Could it be a problem on Google Play Music side?

nikdoof commented 9 years ago

Sounds like it could be related to #246

hkernbach commented 9 years ago

Had the same issue. Disabling all Notifications and MiniPlayer features seems to fix the freezes, just for the moment.

DataGreed commented 9 years ago

I don't want to sound annoying, but is someone still maintaining radiant?

DataGreed commented 9 years ago

@kbhomes ?

btorellALTA commented 9 years ago

@hkernbach's workaround seems to have fixed it for me. I had already disable the mini player, but I was still getting freezing. Disabling notifications as well seems to have removed the crashing/freezing completely.

DataGreed commented 9 years ago

But i love the miniplayer and notifications :(

DataGreed commented 9 years ago

Funny thing: the bug may be hardware-related or related to the speed of storage (?).

The radiant 1.3.1 works perfectly fine on latest 2014 macbook pro retina with ssd, so I am getting problems only on my 2009 mac pro with HDD.

To other commenters: please add your device info

belak commented 9 years ago

I've got a 2013 Retina MacBook Pro and 2014 Retina MacBook pro, both with SSD. And both run into the issue.

DataGreed commented 9 years ago

Seems I guessed wrong :)

belak commented 9 years ago

Worth a guess though. I'm pretty sure the issue is with notifications, but I haven't been able to do a useful bisect because the issue doesn't always show up right away.

jonasfa commented 9 years ago

Radiant freezes only when I'm using the custom Yosemite theme (the one with translucency/glass effect). Never froze again after I've switched to the default (not custom) theme.

MacBook Pro (Retina, 15-inch, Early 2013)

DataGreed commented 9 years ago

@jonasfa dang, you must be right! I also switched to this theme only on one of the environments (which had freezing issues), that may solve the issue, I'll give it a go, thank you!

belak commented 9 years ago

I have not run into the issues with the Yosemite theme and notifications disabled, but I have run into the application freezing with the theming disabled but notifications on. That being said, I haven't gotten the audio skipping just yet with the normal theme... but it is displaying all the other symptoms.

It could just be some unknown interaction with Yosemite in general that isn't even clear.

marten-seemann commented 9 years ago

Any progress on this issue? The freezes are really annoying.

DataGreed commented 9 years ago

Well, I've disabled custom theme and the issue is still present :(

kbhomes commented 9 years ago

I'm currently investigating, though I'm finding little time now because of work and school commitments. I should have more time to look into this in the following weeks.

hu5h55 commented 9 years ago

Thank you for your hard work!

Br, Niclas

On Sun, Dec 7, 2014 at 10:28 PM, Sajid Anwar notifications@github.com wrote:

I'm currently investigating, though I'm finding little time now because of work and school commitments. I should have more time to look into this in the following weeks.

— Reply to this email directly or view it on GitHub https://github.com/kbhomes/radiant-player-mac/issues/262#issuecomment-65955946 .

DataGreed commented 9 years ago

@kbhomes thank you!

intel352 commented 9 years ago

I'm experiencing this issue as well, 10.10.1, fully loaded MacBook Pro (Retina, 15-inch, Mid 2014). App will completely freeze (OSX recognizes app as not responding), or else app will freeze (but not recognized by OSX), and then resume playback once it has started responding again.

When the app freezes mid-song, the song kinda echoes to nothing.

ShutterMunster commented 9 years ago

Having the same issue on 10.10.1. I'm on a 6 core Mac Pro (trash can). I love your work on the app and will gladly donate once this freezing issue is resolved. It seems that disabling mini player and notification is doing the trick for now, but of course that's not a proper solution. Don't kill yourself though, when you have the time give it a look. Happy Holidays kid!

andrewjkerr commented 9 years ago

I've noticed the same thing, but only when I'm on the queue screen. If I'm not on the queue screen I won't notice any hangs at all.

However, I've noticed that the hangs will either be freezing or freezing AND a very unpleasant noise (I can't really describe it.) The noise seems to only happen when playing from a radio station.

I've got an Early 2011 15" MBP on 10.10.1 - 8GB RAM, 256GB SSD & 750GB HDD.

hutchy2570 commented 9 years ago

I've also noticed it only happens when the Queue screen is open, and normally when I'm using radio. I managed to sample the app during a hang today. Don't know if it's of any use?

https://gist.github.com/hutchy2570/76f57ac54290e67b46b7

hutchy2570 commented 9 years ago

Just an update to this. I've started seeing freezes when not on the queue page, and when not using Radio, so it doesn't seem to be just limited to those scenarios. The hangs seem shorter when not on the queue page though.

dodgepong commented 9 years ago

Been using the program for several months now, and ever since disabling notifications, it has run flawlessly.

hutchy2570 commented 9 years ago

@dodgepong is right. I disabled notifications 3 days ago after seeing his comment and the problem has completely disappeared.

matthewlloyd commented 9 years ago

Disabling notifications worked for me too. I'm not really a Cocoa developer but based on symptoms, my guess is that the HTTP request to get the album thumbnail for the notification is blocking the main UI thread somehow.

matthewlloyd commented 9 years ago

Took a quick look, my hunch was correct, as confirmed by a read of the code and the gist stack thread posted at the top of this conversation. The problem is this line:

https://github.com/kbhomes/radiant-player-mac/blob/master/radiant-player-mac/Notifications/NotificationCenter.m#L78

If the HTTP request for the image takes a long time, it hangs the entire application until it either succeeds or times out. The fix would be to have the notification (or just the image load part if possible) run in a separate thread.

hutchy2570 commented 9 years ago

@matthewlloyd I turned notifications back on and started getting hangs again, turned off the album art in notifications and the hangs stopped occurring, so looks like that is the culprit. Hopefully it's an easy fix as album art in the notification is quite nice.

DataGreed commented 9 years ago

Can it be also a culprit of CPU hoging?

kbhomes commented 9 years ago

Could you guys take a look at #280 and run the pre-release version, see if you're having any problems still?

hu5h55 commented 9 years ago

Thanks man, will try it out through the day. Regards Niclas

On Mon, Feb 16, 2015 at 3:30 AM, Sajid Anwar notifications@github.com wrote:

Could you guys take a look at #280 https://github.com/kbhomes/radiant-player-mac/issues/280 and run the pre-release version, see if you're having any problems still?

— Reply to this email directly or view it on GitHub https://github.com/kbhomes/radiant-player-mac/issues/262#issuecomment-74452461 .

ShutterMunster commented 9 years ago

Turning on notifications and giving the new one a shot now. Working well so far. Will report otherwise. 

Thanks kid!


Roman France Motion // Stills RomanM Photography

On February 15, 2015 at 9:30:07 PM, Sajid Anwar (notifications@github.com) wrote:

Could you guys take a look at #280 and run the pre-release version, see if you're having any problems still?

— Reply to this email directly or view it on GitHub.

hu5h55 commented 9 years ago

Seems to be stable so far! Will report if I find anything. Thanks! Keep up the good work!

On Mon, Feb 16, 2015 at 10:05 AM, ShutterMunster notifications@github.com wrote:

Turning on notifications and giving the new one a shot now. Working well so far. Will report otherwise.

Thanks kid!


Roman France Motion // Stills RomanM Photography

On February 15, 2015 at 9:30:07 PM, Sajid Anwar (notifications@github.com) wrote:

Could you guys take a look at #280 and run the pre-release version, see if you're having any problems still?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/kbhomes/radiant-player-mac/issues/262#issuecomment-74477598 .

kbhomes commented 9 years ago

Thanks for the heads up @matthewlloyd, I just pushed a fix for that problem.