search

radiant / radiant-rss_reader-extension

Feed reader for Radiant CMS
0 stars 0 forks source link

Stopped working on ruby 1.9 #1

Open jomz opened 10 years ago

jomz commented 10 years ago

ruby-feedparser 0.7.0 trips over UTF8/ASCII encoding issues in ruby 1.9. I tried using feedparser 0.9.3 to fix this, but that version seems to have stopped working altogether..; FeedParser::Feed::new is supposed to take a string with the content of the feed (according to the tests), but when I try that, I get ArgumentError: wrong number of arguments(1 for 0)...

ruby-feedparser seems abandoned, so I gave up trying to fix this.

I have switched to feed_reader which seems to still work. I did have to require feedzirra in my Gemfile, make sure to specify 

gem 'feedzirra', '~> 0.7.1'

Because 0.8.0 is an empty gem that nudges you to use feedjira. I don't have the time atm to update feed_reader into a gem depending on feedjira, but figured this info may help someone..

avonderluft commented 10 years ago

Thanks Benny, I'll take a look when I get a chance. If/when you have time, I'd be happy to have you make further improvements to this extension. Would you like me to add you as an author on the gem? Happy to do so.