Fix EO example - Githubissues

radiantearth / stac-spec

SpatioTemporal Asset Catalog specification - making geospatial assets openly searchable and crawlable

https://stacspec.org

Apache License 2.0

794 stars 178 forks source link

Fix EO example #1000

Closed m-mohr closed 3 years ago

m-mohr commented 3 years ago

Related Issue(s): None (but let's celebrate PR/issue #1000) ✨

Proposed Changes:

Not exactly sure how it happened, but the EO example got corrupted. (edit: It was a bug in stac-node-validator)

PR Checklist:

[x] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[x] This PR has no breaking changes.
[x] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
[ ] This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

cholmes commented 3 years ago

Hrm, I think this will be a conflict with #955 as I got rid of this example. I'll approve, but would probably prefer to just delete it so I don't have to resolve the conflict on that merge.

cholmes commented 3 years ago

And awesome work everyone on #1000!

cholmes commented 3 years ago

We could run the check with the fix on the refresh-examples branch?

m-mohr commented 3 years ago

I don't understand your last comment. On the other hand, we could just merge and then I'll resolve the conflict. That should be easy as the file got deleted in #955.

m-mohr commented 3 years ago

I've merged this into the examples refresh PR so that it doesn't give merge conflicts. So in the meantime it would be great to merge this so that the CI in PRs is not failing. Could someone approve? @matthewhanson @jbants