Restored UML diagram - Githubissues

radiantearth / stac-spec

SpatioTemporal Asset Catalog specification - making geospatial assets openly searchable and crawlable

https://stacspec.org

Apache License 2.0

794 stars 178 forks source link

Restored UML diagram #1051

Closed hgs-msmith closed 3 years ago

hgs-msmith commented 3 years ago

Updated to spec version 1.0.0

Related Issue(s): #1030

Proposed Changes:

Updated to spec version 1.0.0

PR Checklist:

[x] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[x] This PR has no breaking changes.
[ ] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
[ ] This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

cholmes commented 3 years ago

@hgs-msmith - one of the changes we made in 1.0.0-rc.1 is that collection no longer inherits from catalog. Could you update the UML so it doesn't have that relationship?

philvarner commented 3 years ago

After the mtg this morning, it dawned on me what the problem is and what the relation is:

Catalog and Collection have a has-a relationship -- a Catalog has-a zero-or-more Collections.
Collection is NOT a Catalog (is-a)
Collection and Catalog both is-a (are-a?) "STAC Aggregate" -- they both relate together other object (a Collection relates together other Collections and Items; a Catalog relates together other Catalogs, Collections, and Items). Aggregate is probably a bad term to use here b/c it's too easy to get confused with SQL-like aggregation functions instead of having the domain-driven design meaning.
I think it's actually simpler just to say they're two types not related by subtying through "STAC Aggregate" (or whatever), but happen to have several fields that are named the same.

hgs-msmith commented 3 years ago

Updated UML diagram to remove inheritance relationship between Collection and Catalog.

hgs-msmith commented 3 years ago

Thanks, Matthias. I have incorporated all of these changes.