radiantearth / stac-spec

SpatioTemporal Asset Catalog specification - making geospatial assets openly searchable and crawlable
https://stacspec.org
Apache License 2.0
794 stars 178 forks source link

Validate scientific extension, update for #1045 (merge after scientific extension 1.0.0 release) #1103

Closed cholmes closed 3 years ago

cholmes commented 3 years ago

Related Issue(s): #1093 https://github.com/stac-extensions/scientific/pull/2

Proposed Changes:

  1. Bring in the updated scientific example, so we can release rc.3 without waiting on https://github.com/stac-extensions/scientific/pull/2, as discussed in https://github.com/radiantearth/stac-spec/pull/1093/files#r620248117

PR Checklist:

m-mohr commented 3 years ago

I don't understand this PR? Do we remove the example for RC3 through #1104 and then add it back again after RC3? In this case the Schema URL needs to update from 1.0.0 to 1.0.1.

cholmes commented 3 years ago

I thought that's what you were intending, but I wasn't sure, so happy to take another route.

My take was we should try to release rc.3 asap, and if it's an example of an extension that is blocking us then we should just take that out. But I think it's a good example, so whenever it's in good shape then we should merge it back in.

But if it can happen today/tomorrow I'm for just merging in the scientific fix and cutting 1.0.1 from there as the route to unblock this.

m-mohr commented 3 years ago

So this PR is not meant to be merged for RC3, understood. Then we need to update the schema URI, of course.

m-mohr commented 3 years ago

Looking at it again, I think we could simply not merge it and have these examples in the corresponding extension repos. It's nothing major anyway.