CI Validation - Githubissues

radiantearth / stac-spec

SpatioTemporal Asset Catalog specification - making geospatial assets openly searchable and crawlable

https://stacspec.org

Apache License 2.0

794 stars 178 forks source link

CI Validation #1131

Closed jbants closed 3 years ago

jbants commented 3 years ago

Related Issue(s): #1130

Proposed Changes:

Added python stac-validator to circle ci

PR Checklist:

[x] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[x] This PR has no breaking changes.
[x] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
[ ] This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

m-mohr commented 3 years ago

Why does it try to run publish_schemas here?

jbants commented 3 years ago

I'm not sure. This should capture only tagged versions, correct?

      - publish_schemas:
          filters:
            tags:
              only: /^v.*/
            branches:
              ignore: /^((?!dev).)*$/

https://github.com/radiantearth/stac-spec/blob/dev/.circleci/config.yml#L48-L53

m-mohr commented 3 years ago

Tagged versions and dev. Anyway, it's just dev, so we may not even want to care?

cholmes commented 3 years ago

Why is this failing validation? I don't remember 'publish_schemas'...

jbants commented 3 years ago

I'm guessing here, but since I made the PR from my repo instead of the stac-spec repo, my creds (jbants) are not authorized to publish. The error below is what i'm basing this off of.

ProcessError: ERROR: The key you are authenticating with has been marked as read only.
fatal: Could not read from remote repository.

But, like Matthias said, this is for dev.