remove trailing anchor in schema id values - Githubissues

radiantearth / stac-spec

SpatioTemporal Asset Catalog specification - making geospatial assets openly searchable and crawlable

https://stacspec.org

Apache License 2.0

757 stars 180 forks source link

remove trailing anchor in schema id values #1248

Closed philvarner closed 9 months ago

philvarner commented 9 months ago

Related Issue(s):

1247

Proposed Changes:

Change the $id value for all schema definitions to not have # at the end. This is a non-standard naming convention, and has frequently caused problems with the jsonschema python library.

PR Checklist:

[X] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[ ] This PR has no breaking changes.
[X] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
[ ] This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

m-mohr commented 9 months ago

Fine for me. To solve the issue in Python, you also need to update all extensions though.

CI is failing due to an oudated Node version, but I'd love to see the changes being checked by the Node Validator, too.