update ci node to 18 and format all files - Githubissues

radiantearth / stac-spec

SpatioTemporal Asset Catalog specification - making geospatial assets openly searchable and crawlable

https://stacspec.org

Apache License 2.0

784 stars 179 forks source link

update ci node to 18 and format all files #1249

Closed philvarner closed 1 year ago

philvarner commented 1 year ago

Related Issue(s):

n/a

Proposed Changes:

Update CI node to 18
Move remark configuration to package.json
Format all files in line with remark-gfm formatting

PR Checklist:

[X] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[X] This PR has no breaking changes.
[X] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
[ ] This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

m-mohr commented 1 year ago

+1 on the Node updates (maybe better as a separate PR?)

Not so sure whether we want all the noise of the formatting changes in the diff?

philvarner commented 1 year ago

+1 on the Node updates (maybe better as a separate PR?)

Not so sure whether we want all the noise of the formatting changes in the diff?

I put these two "housekeeping" tasks together in the same PR because it was easier. I'd think differently if they were actual changes.