Disallow GeometryCollection, reformatting - Githubissues

radiantearth / stac-spec

SpatioTemporal Asset Catalog specification - making geospatial assets openly searchable and crawlable

https://stacspec.org

Apache License 2.0

784 stars 179 forks source link

Disallow GeometryCollection, reformatting #1294

Closed m-mohr closed 3 months ago

m-mohr commented 3 months ago

Related Issue(s): #1160

Proposed Changes:

Disallow GeometryCollection in Item Spec (as defined in the schema) #1160
Reformatted the Item Field table to be more lightweight by moving geometry, bbox, and collection descriptions to separate sections. Also, clarified that RFC section 3.1 and 3.2 apply, for Geometry Object and null respectively.

PR Checklist:

[x] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[x] This PR has no breaking changes.
[x] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
[ ] This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

m-mohr commented 3 months ago

I thought we were already enforcing it in validation, I'll check, thanks.

See : https://github.com/radiantearth/stac-spec/issues/1160#issue-1035227775

emmanuelmathot commented 3 months ago

yes right, with the coordinates fields

m-mohr commented 3 months ago

This line enforces it, because it doesn't contain GeometryCollection: https://github.com/radiantearth/stac-spec/blob/master/item-spec/json-schema/item.json#L47

If that's fine for you, you could approve it @emmanuelmathot

m-mohr commented 3 months ago

@gadomski @emmanuelmathot Ready for another review.