radiantlab / HDRICalibrationTool

A free, open-source cross-platform interface to help Radiance automate the merging of multiple LDR images into an HDR image.
GNU General Public License v3.0
4 stars 1 forks source link

Response Function Selection and Deletion #28

Closed shantimorrell closed 4 months ago

shantimorrell commented 11 months ago

As a user, I want to upload a camera response function, with the option to remove it if I upload the wrong file, so that I can generate an HDR image.

Background

This is a subtask of #7.

This is the second step of generating an HDR image, coming immediately after uploading the LDR images. Each specific camera has its own camera response function which describes the relationship between the RGB values and the scene’s radiance values.

Therefore, the camera response function is a necessary part of the HDR image generation when using .jpg or .jpeg images as the input LDR images.

Additional information about the HDR image generation process can be found here: HDR Image Generation Tutorial.

Requirements

Design Resources

No design resources exist yet that depict selecting a camera response function. However, the selection mechanism should be very similar to that of uploading LDR images, and a preliminary Figma design can be found here: Figma Prototype.

The prototype needs to be updated to depict displaying the file name (or file path) of the selected camera response function.

Dependencies

The following need to be completed before this issue:

Before being able to run the hdrgen step of the pipeline, the following feature is also required:

Subtasks

None

Estimate

1 week.

Open Questions

Do we want to display only the file name or display the whole path of the selected camera response function?

What layout or grouping of camera settings and camera response function in our user interface makes the most sense?

Acceptance Criteria

  1. The user opens the app.
  2. The user selects the Upload Camera Response Function button.
  3. The dialog window opens and the user can select the file corresponding to the camera response function.
  4. The user confirms the selected file in the dialog window.
  5. The name of the file used for the camera response function is displayed.
  6. The user can click the Remove button to remove the uploaded file.
  7. The user can click the upload button again to find a different file.
  8. The file selection dialog window opens again.
  9. The user confirms the selected file in the dialog window.
  10. The name of the new uploaded file is displayed under the camera response function section.

Stretch goal: Allow the camera response function to be dragged-and-dropped instead if desired.

Definition of Done

Same as listed in the Software Development Process. No additional criteria.