Find a way to check whether hdrgen command succeeds/fails

radiantlab / HDRICalibrationTool

A free, open-source cross-platform interface to help Radiance automate the merging of multiple LDR images into an HDR image.

GNU General Public License v3.0

4 stars 1 forks source link

Find a way to check whether hdrgen command succeeds/fails #64

Closed adulbrich closed 7 months ago

adulbrich commented 8 months ago

by @shantimorrell

App currently assumes this command succeeds, I believe because I was having issues checking if the result was successful previously, and hadn't yet found a way to do this.

Investigate if we can prevent the next step of the pipeline if the hdrgen step fails.

adulbrich commented 8 months ago

Could we save the result from the command and check it? We can consider doing something similar for all commands?

shantimorrell commented 7 months ago

Checked the status slightly differently than the other commands. When hdrgen fails because output1.hdr file exists, the pipeline will now terminate.

Fix is in branch _batchfixes, will open a pr later