search

radiantmediaplayer / rmp-vast

A client-side JavaScript solution to load, parse and display VAST 2, 3 & 4 resources with HTML5 video
https://www.radiantmediaplayer.com/rmp-vast/app/
Other
95 stars 37 forks source link

Make ad skippable after clickthrough #35

Closed cutepetric closed 3 years ago

cutepetric commented 3 years ago

If you click on a linear ad during non-skippable time frame, the video pauses and the skip button remains unclickable. I've made the ad skippable immediately after clicking on it.

radiantmediaplayer commented 3 years ago

Hi, Thanks for contributing. I do not understand the issue you are trying to fix:

If you click on a linear ad during non-skippable time frame, the video pauses and the skip button remains unclickable.

When a linear ad is clicked VAST player is supposed to go to pause. This is per design. If the ad is not within skippable range when the click happen, then the skip button should not be usable until VAST player has resumed and the skippable range has been reached. Only when the skippable range has been reached then the skip button shall become usable.

Can you please provide more information on what is the issue you are trying to address?

cutepetric commented 3 years ago

I'm experimenting the use of the rmp-vast for displaying outstream video ads.

I think that since the user has clicked on the creative, the goal of the ad is achieved and it's reasonable that when the user returns to the player, he can skip the rest of the ad, even if the skippable range hasn't been reached. I don't know if this behavior breaks any standard, but it looks logical to me.

On Thu, 28 Jan 2021 at 17:40, radiantmediaplayer notifications@github.com wrote:

Hi, Thanks for contributing. I do not understand the issue you are trying to fix:

If you click on a linear ad during non-skippable time frame, the video pauses and the skip button remains unclickable.

When a linear ad is clicked VAST player is supposed to go to pause. This is per design. If the ad is not within skippable range when the click happen, then the skip button should not be usable until VAST player has resumed and the skippable range has been reached. Only when the skippable range has been reached then the skip button shall become usable.

Can you please provide more information on what is the issue you are trying to address?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/radiantmediaplayer/rmp-vast/pull/35#issuecomment-769172368, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKNCYBF4ODMLURPWJHYETTS4GAQPANCNFSM4WVAU4GQ .

radiantmediaplayer commented 3 years ago

As far as I can remember we implemented this behaviour as per VAST 4.2 specs. Unless there is a clear indication that this behaviour goes against standard, then we won't change it. If you want that change you will have to maintain it in your own branch.