search

radiantmediaplayer / rmp-vast

A client-side JavaScript solution to load, parse and display VAST 2, 3 & 4 resources with HTML5 video
https://www.radiantmediaplayer.com/rmp-vast/app/
Other
95 stars 37 forks source link

Incorrect adVerifications parameters in omsdk.js #50

Closed kamtungc closed 2 years ago

kamtungc commented 2 years ago

Please correct omsdk.js.

Incorrect verification parameter: const resources = this.adVerifications.map((verification) => { return new VerificationScriptResource( verification.resource, verification.vendor, verification.verificationParameters, ACCESS_MODE ); });

Correct verification parameter: const resources = this.adVerifications.map((verification) => { return new VerificationScriptResource( verification.resource, verification.vendor, verification.parameters, ACCESS_MODE ); });

References: rmp-vast/src/assets/@dailymotion/vast-client/src/ad_verification.js

export function createAdVerification() { return { resource: null, vendor: null, browserOptional: false, apiFramework: null, type: null, parameters: null, trackingEvents: {}, }; }

radiantmediaplayer commented 2 years ago

This is fixed in 7.1.0.