radiantmediaplayer / rmp-vast

A client-side JavaScript solution to load, parse and display VAST 2, 3 & 4 resources with HTML5 video
https://www.radiantmediaplayer.com/rmp-vast/app/
Other
95 stars 37 forks source link

How to allow auto height of the rmp-container #56

Closed Tomek104104 closed 1 year ago

Tomek104104 commented 1 year ago

How to allow auto height of the rmp-container ? sometimes video ads have 1x1 proportion, sometime 16:9 I'm trying to get always 100% width with auto height

in most of the cases VAST does not provide height so rmpVast.getAdMediaHeight() gives -1

it looks that rmp-container required declared initial, fixed value

radiantmediaplayer commented 1 year ago

Hi, See an example of implementation https://github.com/radiantmediaplayer/rmp-vast/blob/master/app/index.html. You can set size of container with CSS or JavaScript. If you need to change size dynamically see fullscreen handling in demo app.

Tomek104104 commented 1 year ago

Hi thank you for the reply my problem is a bit different I want to have always same width of the video ad and height to be dynamically changed - but not full screen when I have container 16x9 i see correctly 16:9 video [image: image.png] but when I have 1:1 video, video is forced in the same container [image: image.png] and I want to have container auto adjust in height (to get full width of the 1x1 video) question is if there is any way to get actual size of the video (visible width) other then getAdMediaWidth() as this is based on video size info provided in VAST xml (what is usually not provided)

br Tomek

pon., 14 lis 2022 o 17:52 radiantmediaplayer @.***> napisał(a):

Hi, See an example of implementation https://github.com/radiantmediaplayer/rmp-vast/blob/master/app/index.html. You can set size of container with CSS or JavaScript. If you need to change size dynamically see fullscreen handling in demo app.

— Reply to this email directly, view it on GitHub https://github.com/radiantmediaplayer/rmp-vast/issues/56#issuecomment-1314070265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQM2DW2DJNRPUEUFI7COJ4TWIJU3DANCNFSM6AAAAAAR7U2AFI . You are receiving this because you authored the thread.Message ID: @.***>

radiantmediaplayer commented 1 year ago

This is something you need to figure on your side. We do not support implementation issue.

Tomek104104 commented 1 year ago

well, it is your library that handles VAST my question was if there is any feedback available from your handler so I've asked you

of course implementation is on my side IMA SDK automatically handles this problem and shows video always fitted to full width of the div

anyhow, thanks I will try to play around

T

pon., 14 lis 2022 o 18:21 radiantmediaplayer @.***> napisał(a):

This is something you need to figure on your side. We do not support implementation issue.

— Reply to this email directly, view it on GitHub https://github.com/radiantmediaplayer/rmp-vast/issues/56#issuecomment-1314113681, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQM2DW3P4ZRG6SYMJC4NCJ3WIJYH7ANCNFSM6AAAAAAR7U2AFI . You are receiving this because you authored the thread.Message ID: @.***>