radiantmediaplayer / rmp-vast

A client-side JavaScript solution to load, parse and display VAST 2, 3 & 4 resources with HTML5 video
https://www.radiantmediaplayer.com/rmp-vast/app/
Other
95 stars 37 forks source link

vastXmlInput doesn't appear to work #62

Closed Qt-Dan closed 5 months ago

Qt-Dan commented 5 months ago

I have downloaded the example (raw-xml-input.html/js) and am running it on localhost. However I am receiving this error: xhr_url_handler.js:58 GET http://localhost:9001/%3C?xml%20version=%221.0%22%20encoding=%22UTF-8%22?%3…/Linear%3E%3C/Creative%3E%3C/Creatives%3E%3C/InLine%3E%3C/Ad%3E%3C/VAST%3E

It's trying to do a GET call on the xml being passed into the loadAds call, completely ignoring the vastXmlInput parameter.

I tested this on the latest available version, 14.0.1. Please see attached for the files I'm using, I simply stripped away the jasmine code. I feel like this is the most basic use case and should work, what am I missing?

raw-xml-input.zip

Qt-Dan commented 5 months ago

I just discovered the issue lies with using rmp-vast.min.js. If I use the debug version than it works. Looking through the browser debugger it looks like index.js has a copyright year of 2022 and doesn't even contain the parameter in the file - somehow rmp-vast.min.js hasn't been updated.

radiantmediaplayer commented 5 months ago

Hi, I just tested rmp-vast/test/spec/inlineLinearSpec/raw-xml-input.html with our latest release 14.0.1 with both rmp-vast.js and rmp-vast.min.js and I could see it working as expected. Please make sure to use the latest release, there is no file with Copyright dating 2022 in the latest release.