search

radiasoft / download

Install scripts for "curl | bash"
Apache License 2.0
3 stars 5 forks source link

all install_vars_export's need an eval in front of them #706

Closed e-carlin closed 3 months ago

e-carlin commented 3 months ago

I'm running into environment not being cascaded properly. Specifically, here. In that case install_version_centos is set to the default even if I set it when calling the installer. install_vars_export echo's out the declare statements which I think we need to then eval. So, the code should be changed to eval $(install_vars_export).

We eval in this case. But, not in every other case. Maybe they're all broken too? I haven't looked closely at any of the cases besides the one in vagrant-dev.

@robnagler can you confirm that eval should be added to all calls to install_vars_export?

e-carlin commented 3 months ago

Figured it out. Confusion between evaluation and execution. The call to install_vars_export becomes all of the declare statements when evaluated. They then get executed when the ssh command is executed. Just need to add install_version_centos to the list of variables in install_vars_export.

robnagler commented 3 months ago

Maybe document that you have to do this at the point the vars are declared.