search

radiasoft / download

Install scripts for "curl | bash"
Apache License 2.0
3 stars 5 forks source link

Fix #716 added build module #717

Closed robnagler closed 2 months ago

robnagler commented 2 months ago

Removed tox, should not be necessary at this level

robnagler commented 2 months ago

Some questions to answer:

  • why is tox being removed?
  • why is build being added?
  • when is build used?
  • why is build being installed globally here instead of in relevant pryproject.toml files?
  • Same for setuptools?

https://packaging.python.org/en/latest/guides/modernize-setup-py-project/ explains some. Tox was needed when it was used, but it was only used in development. Since pip install didn't work for any of our modules before pyproject.toml, we didn't run python setup.py test.

I'll update the commit msg.

e-carlin commented 2 months ago

LGTM. Thanks for the info.