search

radiasoft / rslaser

Integrated modeling of CPA crystal-based laser amplifiers
Apache License 2.0
1 stars 1 forks source link

Analytical n2 #58

Closed k-wolfinger closed 1 year ago

k-wolfinger commented 1 year ago

Tests are passing

bruhwiler commented 1 year ago

I reran tests and the comparison notebook, including the most recent update. I also verified that the assertion correctly catches the problematic use case.

Note to @gurhar1133 and @moellep: the signature of the calc_n0n2_fenics method in the Crystal class has changed. It has the new name calc_n0n2 with new parameters. This is a breaking change for Sirepo-Silas.