search

radiasoft / rslaser_old

Integrated modeling of CPA crystal-based laser amplifiers
Apache License 2.0
1 stars 1 forks source link

13 convert efield to photon density #130

Closed k-wolfinger closed 1 year ago

k-wolfinger commented 1 year ago

Ready for review

bruhwiler commented 1 year ago

I don't remember why python-ci test is failing, but will ignore.

bruhwiler commented 1 year ago

Two tests in pulse_test.py are failing: pulse_test.log:tests/pulse_test.py::test_instantiation03 FAILED pulse_test.log:tests/pulse_test.py::test_from_file FAILED

I would guess that test_instantiation03 is failing due to changes in _LASER_PULSE_DEFAULTS and _LASER_PULSE_SLICE_DEFAULTS However, this test is also failing on master, so I think the problem should be resolved outside of this branch.

There are also failures in wavefront_sensor_test.py but again these same failures are observed on master.