search

radiasoft / rslaser_old

Integrated modeling of CPA crystal-based laser amplifiers
Apache License 2.0
1 stars 1 forks source link

Separated optics element classes into dedicated Python files. #139

Closed morhenderson closed 1 year ago

bruhwiler commented 1 year ago

Tests are failing. I'll have a look.

morhenderson commented 1 year ago

It looks like it's failing when trying to import srwlib and related imports.

bruhwiler commented 1 year ago

Yes, I don't understand the srwlib import failures.

morhenderson commented 1 year ago

It should be fixed now. I was just trying to do from srwlib.srwl import PropagElecField in element.py, but I don't think the submodule srwl is set up to have its own submodules. So, I just needed to do from srwlib import srwl and then call srwl.PropagElecField in the code.

bruhwiler commented 1 year ago

Tests are passing for me now. As expected, a number of notebooks are now failing, but I'm not going to fix them for this PR.

bruhwiler commented 1 year ago

python-ci seems to be failing due to some GitHub API issues. I'm going to ignore.