Fix crystal and crystal slice default params

radiasoft / rslaser_old

Integrated modeling of CPA crystal-based laser amplifiers

Apache License 2.0

1 stars 1 forks source link

Fix crystal and crystal slice default params #144

Closed k-wolfinger closed 1 year ago

k-wolfinger commented 1 year ago

Similar to the issue with laser pulse and laser pulse slice params:

the CrystalSlice class constructor should receive a non-hierarchical params object that is created for it within the Crystal constructor
in it's current setup, we cannot make changes to the default params of the CrystalSlice when initializing a Crystal within a notebook, for example

k-wolfinger commented 1 year ago

Also:

While I can set "nslices", I cannot change "_N_SLICE_DEFAULT = 3". This means that initalization fails when I set nslices > 3 because n0, n2 only go up to range(_N_SLICE_DEFAULT).

n0=[_CRYSTAL_SLICEDEFAULTS.n0 for in range(_N_SLICE_DEFAULT)], n2=[_CRYSTAL_SLICEDEFAULTS.n0 for in range(_N_SLICE_DEFAULT)],