search

radiasoft / rslaser_old

Integrated modeling of CPA crystal-based laser amplifiers
Apache License 2.0
1 stars 1 forks source link

remove laser file trimming? #166

Closed moellep closed 1 year ago

moellep commented 1 year ago

The data from the laser files are being trimmed in pulse.py to make the grid 32x32 rather than 40x32. I don't think that is needed, and the code works OK with this. The new notebook in PR #165 can work with either the 32x32 grid or 40x32. https://github.com/radiasoft/rslaser/blob/fe3246643c7ad7eeec2f911708fd8817b8b10c1c/examples/single_pass/SinglePass01-LaserPulse.ipynb

I think the _reshape_data() method should be removed https://github.com/radiasoft/rslaser/blob/master/rslaser/pulse/pulse.py#L878

bruhwiler commented 1 year ago

Agreed.
This has been resolved via pull request #165