search

radiasoft / rslaser_old

Integrated modeling of CPA crystal-based laser amplifiers
Apache License 2.0
1 stars 1 forks source link

156 wrap propagators #169

Closed k-wolfinger closed 1 year ago

k-wolfinger commented 1 year ago

Ready for review

k-wolfinger commented 1 year ago

Not sure why this failed, looking now

k-wolfinger commented 1 year ago

The tests all pass on my local branch of 156, which says it is up to date with origin

bruhwiler commented 1 year ago

I'm not sure why the python-ci test is failing. I will merge the PR anyway.

k-wolfinger commented 1 year ago

Okay, I thought I did clear all, must have missed one.

bruhwiler commented 1 year ago

It is likely that you did the right thing but that a previous developer did not.

A happy outcome can only be achieved if 'clear all' is consistently executed by all developers prior to making commits.