search

radiasoft / rslaser_old

Integrated modeling of CPA crystal-based laser amplifiers
Apache License 2.0
1 stars 1 forks source link

46 37 laser pulse length and cavity update #47

Closed gurhar1133 closed 2 years ago

gurhar1133 commented 2 years ago
bruhwiler commented 2 years ago

The code looks good to me; however, the following test script is throwing an exception https://www.sirepo.com/jupyter/user/bruhwiler/lab/tree/work/rslaser/examples/cavity/simple_cavity.py

Two notebooks also require updating to work with the new API: https://www.sirepo.com/jupyter/user/bruhwiler/lab/tree/work/rslaser/examples/notebooks/cavity/TestCavityFull.ipynb and https://www.sirepo.com/jupyter/user/bruhwiler/lab/tree/work/rslaser/examples/notebooks/cavity/TestCavity.ipynb

gurhar1133 commented 2 years ago

I can work on those. Should we open a separate issue for them or would you like me to get going on them before we go forward with merging this PR?