search

radiasoft / rslaser_old

Integrated modeling of CPA crystal-based laser amplifiers
Apache License 2.0
1 stars 1 forks source link

Fix #62 tests for CrystalSlice and LaserPulseEnvelope #65

Closed gurhar1133 closed 2 years ago

gurhar1133 commented 2 years ago

Tests for both classes added Currently 'attenuate', 'default', and 'placeholder' prop_types for CrystalSlice.propagate() are not fully implemented and tests check that calling .propagate() with those modes does fire exceptions Drift and Lens propagation tests added as well

bruhwiler commented 2 years ago

Sorry -- I just noticed that @e-carlin was also asked to review. The new tests look good to me.

gurhar1133 commented 2 years ago

Sorry -- I just noticed that @e-carlin was also asked to review. The new tests look good to me.

np, I can have him review next pr concerning that code.