Fix #66 crystal as container

radiasoft / rslaser_old

Integrated modeling of CPA crystal-based laser amplifiers

Apache License 2.0

1 stars 1 forks source link

Fix #66 crystal as container #67

Closed gurhar1133 closed 2 years ago

gurhar1133 commented 2 years ago

Crystal is now a container for CrystalSlices ( with nslice slices in a crystal each having length = Crystal.length/Crystal.nslices)
Inputs changed to PKDict with validation
LaserBase changed to be a general validation base class
lines 83-87 of laser_cavity.py:
```
if type(e) == element.Crystal:
e.propagate(l, 'abcd')
else:
e.propagate(l)
```
is a temporary fix (currently 'abcd' is the only working propagation type

bruhwiler commented 2 years ago

In element.py -- please delete the following lines:

from asyncore import read from importlib.resources import read_text import math from telnetlib import EL from array import array

c_light = 299792458.0 # m/s, in vacuum

bruhwiler commented 2 years ago

I don't think we should create a new subdirectory validation/ for the ValidatorBase class. I recommend moving validator.py to utils/ or perhaps to optics/

gurhar1133 commented 2 years ago

I think utils would be a good idea. Since it is used in optics/ cavity/ and pulse/

gurhar1133 commented 2 years ago

Made those changes. LMK if anything else @moellep , @bruhwiler