Closed gurhar1133 closed 1 year ago
@gurhar1133 -- the tests aren't passing. Can you comment?
I resolved some of the errors by doing a fresh 'pip install -e .' of the repo main branch. The 'ndiff' errors will be resolved when an updated Docker image gets pushed to production.
I request that you fix the z_waist failures with the envelope_test. I think this requires only a very small change.
Otherwise, I've reviewed the code changes and they look good to me.
The z_waist problem can be fixed in a separate issue. Fine to merge this PR
Now the LaserPulse takes an optional parameter
files
(a pkdict of paths to files). By default, files is None.I wrote some tests for instantiation, to make sure that we only use this option when nslice is 1 (triggers assertion otherwise), and an ndiff test to examine the laser pulse slice wavefront obtained from the file
.