search

radiasoft / sirepo

Sirepo is a framework for scientific cloud computing. Try it out!
https://sirepo.com
Apache License 2.0
64 stars 31 forks source link

generate subsimulation run files during template.omega write_parameters #6653

Open moellep opened 9 months ago

moellep commented 9 months ago

Currently the omega app creates a parameters.py file which collects all the sims, modifies them, generates the code and runs each one.

Instead, all the code generation should happen in template.omega write_parameters(). All the code in the generated parameters.py up to and including the prep_run_dir() should happen before, and not included in the parameters.py.

The parameters.py job will be only to run sims and convert data between them.

robnagler commented 9 months ago

FYI #6636 will be making a full api for moving files between simulation directories and sim types. It would be good if this gets fixed up in omega. I will be fixing up all the sim_data calls, but any simulation_db calls will be in place. These should get moved to sim_data or (lower level) sim_db_file calls.