radiasoft / sirepo

Sirepo is a framework for scientific cloud computing. Try it out!
https://sirepo.com
Apache License 2.0
64 stars 32 forks source link

elegant: improve source page to include non-gaussian definition #716

Closed moellep closed 7 years ago

moellep commented 7 years ago

The elegant source page does not cover all the options in the bunched_beam command. The fields can be edited from the Control tab, but it would be nice to allow selecting and configuring non-gaussian beams from the source UI as well.

robnagler commented 7 years ago

To be clear, we should be able to set all these parameters (Pages 1-5) on the Source page when you click on the pencil from the bunch?

bunch screen
moellep commented 7 years ago

I don't think we want every parameter. But it would be nice to define a uniform distribution beam, or to control the distribution of one axis. It would be nice if the fields were displayed in a nice manner - for example, rather than fields for distribution_type "gaussian,gaussian,hard-edge" with a distribution_cutoff "1,2,3", split them into a grid with x,y,z columns (6 fields instead of 2).

See the bunched_beam description in the manual: www.aps.anl.gov/asd/oag/manuals/elegant_latest/elegant.pdf

Also look at the bunched beam examples in the elegantExamples.tar.gz file.

moellep commented 7 years ago

@mkeilman One improvement needed for #716 is to separate out some of the elegant beam fields. For example, elegant specifies the X/Y/Z distributions in one comma-separated field. So instead of typing in "gaussian, gaussian, uniform-ellipse", it should be displayed inline as three drop-down elements, each with an enum value ("gaussian", "hard-edge", "uniform-ellipse", ...).

A similar change was made to the InputFileXY field type - elegant expects the value as a string in the format "=+", so the schema separates it into three fields, for example "waveform", "waveformX" and "waveformY".

Below is the elegant bunched_beam page and you can see several combined fields such as "Distribution Cuttoff" and Centroid.

screen shot 2017-08-14 at 9 16 05 am
moellep commented 7 years ago

The new Bunch layout now allows setting many new parameters, including the x/y/z distributions, halton sequences and beam position. Below are some examples.

screen shot 2017-09-07 at 5 09 01 pm screen shot 2017-09-07 at 5 09 48 pm screen shot 2017-09-07 at 5 09 09 pm

bruhwiler commented 7 years ago

@sdwebb and @cchall -- do you think meets the needs of your TESSA collaborators?

moellep commented 7 years ago

This is also available now on alpha.sirepo.com

On Thu, Sep 7, 2017 at 5:30 PM, David Bruhwiler notifications@github.com wrote:

@sdwebb https://github.com/sdwebb and @cchall https://github.com/cchall -- do you think meets the needs of your TESSA collaborators?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/radiasoft/sirepo/issues/716#issuecomment-327956035, or mute the thread https://github.com/notifications/unsubscribe-auth/AGNwrinuc5f1HHXrNrHBYAuW9M8mDgfeks5sgHyxgaJpZM4M3Z5E .

cchall commented 7 years ago

That looks like just what we need. Thanks!

On Fri, Sep 8, 2017 at 12:14 PM, Paul Moeller notifications@github.com wrote:

This is also available now on alpha.sirepo.com

On Thu, Sep 7, 2017 at 5:30 PM, David Bruhwiler notifications@github.com wrote:

@sdwebb https://github.com/sdwebb and @cchall https://github.com/cchall -- do you think meets the needs of your TESSA collaborators?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/radiasoft/sirepo/issues/716#issuecomment-327956035, or mute the thread https://github.com/notifications/unsubscribe-auth/ AGNwrinuc5f1HHXrNrHBYAuW9M8mDgfeks5sgHyxgaJpZM4M3Z5E .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/radiasoft/sirepo/issues/716#issuecomment-328176645, or mute the thread https://github.com/notifications/unsubscribe-auth/AQSGGJSl4_ZQWfcbhNVdg97hJLvjE69yks5sgYQCgaJpZM4M3Z5E .