search

radiate-framework / framework

A WordPress plugin and theme framework
https://radiate-framework.github.io/
MIT License
4 stars 0 forks source link

`Str::random()` wants a string as the first parameter #154

Closed BenRutlandWeb closed 3 years ago

BenRutlandWeb commented 3 years ago

Describe the bug Str::random() accepts a string as the first parameter, then an integer as the second. This is weird behaviour as the method should only require an integer - the string is never used.

To Reproduce Steps to reproduce the behaviour:

  1. use the Str::random() function
  2. Check the method signature
  3. View the method

Expected behaviour random should only accept one parameter - the integer for string length.

Additional context This is a side effect of using Str as a facade for Stringable