Fix/plot origin - Githubissues

radical-cybertools / radical.analytics

Analytics for RADICAL-Cybertools

Other

1 stars 1 forks source link

Fix/plot origin #122

Closed andre-merzky closed 4 years ago

andre-merzky commented 4 years ago

This PR fixes:

plot origin for the ra-inspect plots
correct determination of the plot cancellation timestamp

The latter is achieved by supporting a substring match on msg event matches.

andre-merzky commented 4 years ago

So far, no one uses stand alone utilities to create plots for publications. Not for publications, but I use those utilities at least when I need to understand how a session behaves.

I would focus on producing utlis/tools that can be used in a notebook context. From a cursory look at it, this seems fine. Using a wikipage to derive the list of events seems very fragile to me.

Fair, but that is not what this PR is about, really - it fixes the origin of an existing plot type and some other minor fixes / enhancements...

mturilli commented 4 years ago

Sure. What about the use of the wikipage?

andre-merzky commented 4 years ago

Sure. What about the use of the wikipage?

That's also not really touched by this PR (just a whitespace change (if you look at the diff with whitespace changes turned off, the diff becomes much simpler btw). Also, it's not a wiki page really but is installed along with RP - it happens to be in makdown as to maintain some human readability. I don't have a cleaner solution for this implemented yet :-/