search

radical-cybertools / radical.analytics

Analytics for RADICAL-Cybertools
Other
1 stars 1 forks source link

Enables arbitrary unit durations for duration method #134

Closed mturilli closed 3 years ago

mturilli commented 4 years ago

This enable defining arbitrary units durations for get_consumed_resources. This allows to correctly plot resource utilization when some event timestamps are not available. It is backward compatible with the previous API. Depends on https://github.com/radical-cybertools/radical.pilot/pull/2205

mturilli commented 4 years ago

Thanks! Note that 991 triggers E1121 because, I guess, it installs the master version of rp.utils. Any idea how I would tell Travis to use a specific branch for rp.utils?

andre-merzky commented 4 years ago

Note that 991 triggers E1121 because, I guess, it installs the master version of rp.utils. Any idea how I would tell Travis to use a specific branch for rp.utils?

@iparask : any suggestion?

iparask commented 3 years ago

In travis.yml, we can add something like pip install https://github.com/radical-cybertools/radical.utils.

codecov[bot] commented 3 years ago

Codecov Report

Merging #134 (8ef2843) into devel (61d65e0) will not change coverage. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #134   +/-   ##
=======================================
  Coverage   24.42%   24.42%           
=======================================
  Files           5        5           
  Lines         921      921           
=======================================
  Hits          225      225           
  Misses        696      696
Impacted Files Coverage Δ
src/radical/analytics/experiment.py 25.92% <50.00%> (ø)
src/radical/analytics/session.py 6.64% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61d65e0...8ef2843. Read the comment docs.