search

radical-cybertools / radical.analytics

Analytics for RADICAL-Cybertools
Other
1 stars 1 forks source link

guess the etype #166

Closed andre-merzky closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #166 (60e5e3d) into devel (81e491c) will increase coverage by 0.13%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            devel     #166      +/-   ##
==========================================
+ Coverage   22.67%   22.81%   +0.13%     
==========================================
  Files           7        7              
  Lines        1107     1109       +2     
==========================================
+ Hits          251      253       +2     
  Misses        856      856
Impacted Files Coverage Δ
src/radical/analytics/entity.py 74.65% <100.00%> (+0.23%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

andre-merzky commented 1 year ago

LGTM!

p.s. for updated raptor profiling, should we have etypes with the underscore (e.g., raptor_master, raptor_worker, raptor_task)?

I actually had that at some point, but this is now sufficiently well handled here, and etype should always be set for raptor tasks so that the fallback from this PR does not apply.