search

radical-cybertools / radical.analytics

Analytics for RADICAL-Cybertools
Other
1 stars 1 forks source link

Issue with the concurrency (sampling) #180

Closed mtitov closed 11 months ago

mtitov commented 11 months ago

https://github.com/radical-cybertools/radical.analytics/blob/b0ce0773e51756cd1c6694973b05c3a3de8346a2/src/radical/analytics/session.py#L860-L865

shouldn't this code be as

            t     = times[0][0]
            v     = collapsed[0][1]
            ret   = list()
            for time, val in collapsed:
                while time > t:
                    ret.append([t, v])
                    t += sampling
                v = val

when used the original code as concurrency(event=events, sampling=1) then had less concurrent tasks by 1 (-1) as it should be

andre-merzky commented 11 months ago

Nice catch, correct I think...