Feature/entk integration

radical-cybertools / radical.analytics

Analytics for RADICAL-Cybertools

Other

1 stars 1 forks source link

Feature/entk integration #82

Closed vivek-bala closed 5 years ago

vivek-bala commented 5 years ago

This is an old branch which lets users use analytics with EnTK. A few commits were left out in a previous merge. Current feature/entk-integration is synced with devel.

andre-merzky commented 5 years ago

The only diff in this PR is the addition of Jumana's wrangler? I am happy to merge that of course, but wanted to check with you if this was the intent for this PR?

vivek-bala commented 5 years ago

I see. You're right. I think the missing commit did not get merged with master. Specifically, that commit should have included https://github.com/radical-cybertools/radical.analytics/blob/devel/src/radical/analytics/session.py#L97-L98.

andre-merzky commented 5 years ago

Ah, I see - I brought devel and master in sync now, and pushed a new release out (0.50.1), which contains that commit. I'll merge this PR into devel now, so that the wrangler is available there, too.

Thanks!