radical-cybertools / radical.entk

The RADICAL Ensemble Toolkit
https://radical-cybertools.github.io/entk/index.html
Other
28 stars 17 forks source link

Fix/mock #630

Closed andre-merzky closed 1 year ago

andre-merzky commented 1 year ago

The Mock backend broke at some point. This PR brings it back in sync with the RP backend. The PR also contains cosmetic changes for the latter to minimize the diff (makes it easier to maintain both) and to get closer to our coding guidelines.

codecov[bot] commented 1 year ago

Codecov Report

Merging #630 (4fb550a) into devel (4bed026) will increase coverage by 1.54%. The diff coverage is 62.23%.

@@            Coverage Diff             @@
##            devel     #630      +/-   ##
==========================================
+ Coverage   67.93%   69.47%   +1.54%     
==========================================
  Files          22       23       +1     
  Lines        2264     2028     -236     
==========================================
- Hits         1538     1409     -129     
+ Misses        726      619     -107     
Impacted Files Coverage Δ
src/radical/entk/execman/rp/task_manager.py 23.27% <20.00%> (-0.07%) :arrow_down:
src/radical/entk/execman/mock/task_manager.py 19.56% <26.66%> (-12.76%) :arrow_down:
src/radical/entk/appman/appmanager.py 44.50% <54.43%> (-0.47%) :arrow_down:
src/radical/entk/execman/rp/task_processor.py 84.10% <61.11%> (+0.20%) :arrow_up:
src/radical/entk/pipeline.py 88.81% <68.96%> (+0.07%) :arrow_up:
src/radical/entk/stage.py 90.57% <72.72%> (+0.13%) :arrow_up:
src/radical/entk/execman/base/task_manager.py 81.92% <74.07%> (+13.81%) :arrow_up:
src/radical/entk/appman/wfprocessor.py 80.15% <77.04%> (+3.17%) :arrow_up:
src/radical/entk/execman/rp/resource_manager.py 64.00% <87.50%> (ø)
src/radical/entk/__init__.py 100.00% <100.00%> (+13.04%) :arrow_up:
... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mtitov commented 1 year ago

@andre-merzky this branch got merged with no-rmq changes, lets push it towards feature/no_rmq_2 branch then (which will be pushed toward devel). Otherwise there could be some inconsistency..